Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing #30 and changing output behaviour. #33

Merged
merged 2 commits into from
Jun 26, 2021
Merged

Fixing #30 and changing output behaviour. #33

merged 2 commits into from
Jun 26, 2021

Conversation

LazyScholar
Copy link
Contributor

Fixing #30 by changing the string concatenation of xin().
Changed also the behaviour of proceedings and incollection output as there where some logical bugs (please check and correct if necessary).

diff --git a/test/test.bib.txt b/test/test.bib.txt
index 6e25cc8..2a47864 100644
--- a/test/test.bib.txt
+++ b/test/test.bib.txt
@@ -89,7 +89,7 @@ key: CitekeyPhdthesis
 key: CitekeyProceedings
   title: 'Proceedings of the 17th International Conference on Computation and Natural Computation, Fontainebleau, France'
   names: 'Susan Stepney, Sergey Verlan'
-     in: 'Volume 10867 of Lecture Notes in Computer Science, Cham, Switzerland, 2018. Cham, Switzerland.'
+     in: 'Volume 10867 of Lecture Notes in Computer Science, Cham, Switzerland, 2018. Springer.'
    year: '2018'
    link: ''
    file: 'files/CitekeyProceedings.pdf
@@ -41,7 +41,7 @@ key: CitekeyInbook
 key: CitekeyIncollection
   title: 'Flow Cytometry: The Glass Is Half Full'
   names: 'Howard M. Shapiro'
-     in: 'In Teresa S. Hawley, Robert G. Hawley, editors, Flow Cytometry Protocols, 1--10. Springer, New York, NY, 2018.'
+     in: 'In Flow Cytometry Protocols, editors, Teresa S. Hawley, Robert G. Hawley, 1--10. Springer, New York, NY, 2018.'
    year: '2018'
    link: ''
    file: 'files/CitekeyIncollection.pdf'

This should be enough to close the issue as the arXiv links have no direct field representation for xlink().

Azzaare
Azzaare approved these changes Jun 26, 2021
View reviewed changes
Copy link
Member

@Azzaare Azzaare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logic seems good and the results from StaticWebPages are good (actually better than before), so I will merge it.

Thank you again!

@Azzaare Azzaare merged commit 85eab67 into Humans-of-Julia:master Jun 26, 2021
@LazyScholar LazyScholar deleted the fancy_join branch June 26, 2021 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Azzaare Azzaare Azzaare approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LazyScholar @Azzaare